Skip to content

Conversation

@rishivardhanmm
Copy link
Contributor

@rishivardhanmm rishivardhanmm commented Mar 12, 2025

Closes #12703

This is an simple replace text in few files for changing "Cleanup entries" to "Clean up entries"

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Screenshot 1
Screenshot 2

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

@koppor
Copy link
Member

koppor commented Mar 12, 2025

@rishivardhanmm Your PR makes the impression that it was writtein in a rush. Now, please take the time to investigate the comments the bots gave. - Also read on at https://devdocs.jabref.org/code-howtos/localization.html

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

CHANGELOG.md Outdated
- We fixed an issue where migration of "Search groups" would fail with an exception when the search query is invalid. [#12555](https://github.com/JabRef/jabref/issues/12555)
- We fixed an issue where not all linked files from BibDesk in the field `bdsk-file-...` were parsed. [#12555](https://github.com/JabRef/jabref/issues/12555)
- We fixed an issue where JabRef displayed an incorrect deletion notification when canceling entry deletion [#12645](https://github.com/JabRef/jabref/issues/12645)
- We fixed an issue where JabRef displayed "Cleanup entries" instead of "Clean up entries" [#12710](https://github.com/JabRef/jabref/issues/12710)
Copy link
Member

@subhramit subhramit Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this in the "Changed" section instead of "Fixed" as it was not a bug. Re-phrase the line accordingly.

@koppor
Copy link
Member

koppor commented Mar 12, 2025

I am trying out the comment deletion feature koppor/ghprcomment#8

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

@koppor
Copy link
Member

koppor commented Mar 12, 2025

@rishivardhanmm Please fix the issue the bot commetns

I am done with testing.

@rishivardhanmm
Copy link
Contributor Author

@rishivardhanmm Your PR makes the impression that it was writtein in a rush. Now, please take the time to investigate the comments the bots gave. - Also read on at https://devdocs.jabref.org/code-howtos/localization.html

@koppor I made the changes, Please review.

@subhramit
Copy link
Member

@koppor I made the changes, Please review.

Please read again what the bot comments say.

@github-actions
Copy link
Contributor

Your pull request needs to link an issue.

To ease organizational workflows, please link this pull-request to the issue with syntax as described in https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue:

Linking a pull request to an issue using a keyword

You can link a pull request to an issue by using a supported keyword in the pull request's description or in a commit message. The pull request must be on the default branch.

  • close
  • closes
  • closed
  • fix
  • fixes
  • fixed
  • resolve
  • resolves
  • resolved

If you use a keyword to reference a pull request comment in another pull request, the pull requests will be linked. Merging the referencing pull request also closes the referenced pull request.

The syntax for closing keywords depends on whether the issue is in the same repository as the pull request.

Examples

  • Fixes #xyz links pull-request to issue. Merging the PR will close the issue.
  • Fixes https://github.com/JabRef/jabref/issues/xyz links pull-request to issue. Merging the PR will close the issue.
  • Fixes https://github.com/Koppor/jabref/issues/xyz links pull-request to issue. Merging the PR will close the issue.
  • Fixes [#xyz](https://github.com/JabRef/jabref/issues/xyz) links pull-request to issue. Merging the PR will NOT close the issue.

@trag-bot
Copy link

trag-bot bot commented Mar 12, 2025

@trag-bot didn't find any issues in the code! ✅✨

@subhramit
Copy link
Member

The issue is partially solved - there is a second part. Please read the issue and submit a corresponding PR at the user documentation repository, then reference it here in a comment.

@rishivardhanmm
Copy link
Contributor Author

Closes #12703

This is an simple replace text in few files for changing "Cleanup entries" to "Clean up entries"

JabRef/user-documentation#555

Please review

@subhramit
Copy link
Member

JabRef/user-documentation#555

Please review

One change to be addressed in that PR, after that would be ready to merge.

@koppor koppor added this pull request to the merge queue Mar 12, 2025
Merged via the queue into JabRef:main with commit ab9c983 Mar 12, 2025
1 check passed
GuilhermeRibeiroPereira pushed a commit to GuilhermeRibeiroPereira/jabref that referenced this pull request Apr 1, 2025
* replacing "Cleanup entries" to "Clean up entries"

* test formatting changes on CHANGELOG.md

* replacing "Cleanup entries" to "Clean up entries"

* replacing "Cleanup entries" to "Clean up entries"

* Update CHANGELOG.md

Co-authored-by: Subhramit Basu Bhowmick <[email protected]>

* replacing "Cleanup entries" to "Clean up entries"

---------

Co-authored-by: Subhramit Basu Bhowmick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace "Cleanup" by "Clean up"

3 participants